Closed
Bug 836135
Opened 11 years ago
Closed 11 years ago
STK PLAY_TONE does not process any button presses
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(blocking-b2g:tef+, b2g18 fixed, b2g18-v1.0.0 fixed)
RESOLVED
FIXED
blocking-b2g | tef+ |
People
(Reporter: cyang, Assigned: frsela)
Details
(Whiteboard: [cr 436892] QARegressExclude)
Attachments
(3 files)
When PLAY_TONE STK proactive command is sent, the display and tones will not stop even after button presses. For example, for the PDU: D01981030120008202810385073C41424F52543E8E010684020001 I see: RILContentHelper: Received message 'RIL:StkCommand': {"commandNumber":1,"typeOfCommand":32,"commandQualifier":0,"options":{"text":"<ABORT>","tone":"\u0006","duration":{"timeUnit":0,"timeInterval":1}}} Pressing the Close or Back button does nothing, tone continues to play and display text is still up. Pressing the Ok button dismisses the display text but the tone continues to play. UI should respond accordingly and the corresponding terminal responses should be sent on each button press.
Comment 1•11 years ago
|
||
Fernando can you have a look?
Updated•11 years ago
|
Flags: needinfo?(frsela)
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → frsela
Assignee | ||
Comment 2•11 years ago
|
||
This patch stops the tone, and sends the correct response to the STK based on the dialog result
Attachment #708128 -
Flags: review?(21)
Flags: needinfo?(frsela)
Attachment #708128 -
Flags: review?(21) → review+
Assignee | ||
Comment 3•11 years ago
|
||
Landed: https://github.com/mozilla-b2g/gaia/commit/f2f2fe53f53964e8a5e5734b6f4ee8564239b6c9
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 4•11 years ago
|
||
(In reply to Fernando R. Sela [:frsela] from comment #3) > Landed: > https://github.com/mozilla-b2g/gaia/commit/ > f2f2fe53f53964e8a5e5734b6f4ee8564239b6c9 Hi Fernando, I pulled in this patch manually and see that display text gets dismissed but the terminal response values are not sent down. This is true for all three buttons: Close, Back, Ok
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 5•11 years ago
|
||
(In reply to Carol Yang from comment #4) > (In reply to Fernando R. Sela [:frsela] from comment #3) > > Landed: > > https://github.com/mozilla-b2g/gaia/commit/ > > f2f2fe53f53964e8a5e5734b6f4ee8564239b6c9 > > Hi Fernando, I pulled in this patch manually and see that display text gets > dismissed but the terminal response values are not sent down. This is true > for all three buttons: Close, Back, Ok Could you provide me the logcat? (enable DEBUG on settings app (file: js/utils.js) & system app (file: js/icc_cache.js))
Flags: needinfo?(cyang)
Reporter | ||
Comment 6•11 years ago
|
||
Logs when GCF TC 27.22.4.5.1.1 is ran. When "<ABORT>" is displayed for PLAY_TONE STK proactive command, pressing the Close button sends terminal response of 0x00 down instead of 0x10 (STK_RESULT_UICC_SESSION_TERM_BY_USER).
Flags: needinfo?(cyang)
Assignee | ||
Comment 7•11 years ago
|
||
Based on the logcat (709221) the STK command is responded before the user answer. This patch fix this. Also I detected that the GCF test doesn't sent a STK MENU command so no menu is displayed but this affected on some Javascript errors which are also fixed.
Attachment #709609 -
Flags: review?(21)
Attachment #709609 -
Flags: review?(21) → review+
Assignee | ||
Comment 8•11 years ago
|
||
Landed: https://github.com/mozilla-b2g/gaia/commit/7d2f452726ddcd29f5b7a7ceecd380bce19607c6
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 9•11 years ago
|
||
(In reply to Fernando R. Sela [:frsela] from comment #8) > Landed: > https://github.com/mozilla-b2g/gaia/commit/ > 7d2f452726ddcd29f5b7a7ceecd380bce19607c6 Thanks Fernando! I just tested this and everything looks good. Can change #7940 as well as #7864 both be uplifted to v1.0.0 and v1-train as well?
blocking-b2g: --- → tef?
Flags: needinfo?(frsela)
Assignee | ||
Comment 10•11 years ago
|
||
(In reply to Carol Yang from comment #9) > (In reply to Fernando R. Sela [:frsela] from comment #8) > > Landed: > > https://github.com/mozilla-b2g/gaia/commit/ > > 7d2f452726ddcd29f5b7a7ceecd380bce19607c6 > > Thanks Fernando! I just tested this and everything looks good. > Nice to hear :) > Can change #7940 as well as #7864 both be uplifted to v1.0.0 and v1-train as > well? You need to ask the v1 aproval flag (approval‑gaia‑v1) in the patches. I'll ask for them ;)
Flags: needinfo?(frsela)
Assignee | ||
Comment 11•11 years ago
|
||
Comment on attachment 708128 [details]
Patch to stop playing tone when close or back is pressed
NOTE: If blocking-basecamp+ is set, just land it for now.
[Approval Request Comment]
Bug caused by (feature/regressing bug #):
User impact if declined:
Testing completed:
Risk to taking this patch (and alternatives if risky):
Attachment #708128 -
Flags: approval-gaia-v1?(dscravaglieri)
Assignee | ||
Comment 12•11 years ago
|
||
Comment on attachment 709609 [details]
Patch to avoid PLAYTONE STK response when a popup dialog is showed
NOTE: If blocking-basecamp+ is set, just land it for now.
[Approval Request Comment]
Bug caused by (feature/regressing bug #):
User impact if declined:
Testing completed:
Risk to taking this patch (and alternatives if risky):
Attachment #709609 -
Flags: approval-gaia-v1?(dscravaglieri)
Comment 13•11 years ago
|
||
This is blocking partner CS bug so assume should be tef+.
Comment 14•11 years ago
|
||
tef+. Note that this obviates the need for the approval requests.
blocking-b2g: tef? → tef+
Comment 15•11 years ago
|
||
Hi, this patch did not apply cleanly to v1-train or v1.0.0. Please merge manually. The following might work for you, but is only offered as a starting point: git checkout v1-train git cherry-pick -m1 7d2f452726ddcd29f5b7a7ceecd380bce19607c6 <resolve merge conflict, commit> git checkout v1.0.0 git cherry-pick $(git log -n1 v1-train --pretty="%H")
Assignee | ||
Comment 16•11 years ago
|
||
First cherry-pick f2f2fe53f53964e8a5e5734b6f4ee8564239b6c9 Then cherry-pick 7d2f452726ddcd29f5b7a7ceecd380bce19607c6 This order avoids the conflict ;) git checkout v1-train git cherry-pick -m1 f2f2fe53f53964e8a5e5734b6f4ee8564239b6c9 git cherry-pick -m1 7d2f452726ddcd29f5b7a7ceecd380bce19607c6 git checkout v1.0.0 git cherry-pick $(git log -n2 --reverse v1-train --pretty="%H") Applied & git updated
Updated•11 years ago
|
Attachment #709609 -
Flags: approval-gaia-v1?(dscravaglieri)
Updated•11 years ago
|
Attachment #708128 -
Flags: approval-gaia-v1?(dscravaglieri)
Reporter | ||
Comment 17•11 years ago
|
||
Thanks! Got the changes now!
Updated•11 years ago
|
status-b2g18:
--- → fixed
status-b2g18-v1.0.0:
--- → fixed
Comment 18•11 years ago
|
||
Can you please provide steps to verify this fix - as we will blackbox test from the UI?
Assignee | ||
Comment 19•11 years ago
|
||
(In reply to croesch from comment #18) > Can you please provide steps to verify this fix - as we will blackbox test > from the UI? You can use this TESTING patch: https://github.com/frsela/gaia/commit/4a23fd3ecb3a2c6b2537af7fd543bea1eaa29de0 5 seconds after bootup (you can reboot phone after patch is applied) the STK command will be emulated.
Updated•11 years ago
|
Whiteboard: [cr 436892] → [cr 436892] QARegressExclude
Comment 20•11 years ago
|
||
No Test case creation is needed in moztrap for this issue.
Flags: in-moztrap-
Comment 21•11 years ago
|
||
Cannot verify, do not have the tools to test this issue.
You need to log in
before you can comment on or make changes to this bug.
Description
•